Repository navigation
test: compare resolved paths in the symlinked-root scan test (Windows) - #724
Merged
Merged
Conversation
The C54 containment test asserted an exact path string, but on Windows symlink resolution can return an extended-length (\\?\\) path, so the raw-string comparison failed there while the containment behaviour is correct. Compare os.path.realpath of both sides instead. Refs #711
|
Warning Review limit reachedThis organization requires a seat for paid usage-based reviews, including automatic and on-demand reviews. Ask an admin to assign a seat or enable paid usage-based reviews for users without a seat in Billing. Next included review available in 16 minutes. View limit details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
After the C54 fix (#717) merged, Python
masterfails the Windowstestmatrix ontest/unit/scan/test_folder.py::test_make_full_path_accepts_internal_link_and_symlinked_root:Root cause
On Windows, resolving the symlinked root yields an extended-length (
\\?\\) path, so the raw string differs from the unprefixed expected path. The containment behaviour under test (a symlinked root plus an internal link is accepted and points at the right file) is correct — only the exact-string comparison is not platform-portable.Changes
os.path.realpath()of the result and the expected path instead of raw strings (Linux/macOS unaffected). Add the missingosimport.Verification
\\?\\prefix; the behavioural assertion is preserved.Refs #711